MINOR: changed the condition to only check the test topic to reduce the flakiness of the test. #20664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he flakiness of the test.
github-actions
bot
added
triage
mjsax
reviewed
Oct 8, 2025
| String underReplicatedOutput = captureDescribeTopicStandardOut(clusterInstance, buildTopicCommandOptionsWithBootstrap(clusterInstance, "--describe", "--under-replicated-partitions")); | ||
| assertEquals("", underReplicatedOutput, | ||
| assertFalse(underReplicatedOutput.contains(String.format("Topic: %s", testTopicName)), | ||
| String.format("--under-replicated-partitions shouldn't return anything: '%s'", underReplicatedOutput)); |
There was a problem hiding this comment.
Nit: seems the error message would need an update, too?
lianetm
reviewed
Oct 9, 2025
Comment on lines
1201
to
1202
| assertFalse(underReplicatedOutput.contains(String.format("Topic: %s", testTopicName)), | ||
| String.format("--under-replicated-partitions shouldn't contain '%s': '%s'", String.format("Topic: %s", testTopicName), underReplicatedOutput)); |
There was a problem hiding this comment.
nit: should we extract the string formatting bit to a var (good to reuse and would be clearer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINOR: changed the condition to only check the test topic to reduce the
flakiness of the test.
Reviewers: Matthias J. Sax [email protected], Lianet Magrans
[email protected]